Francesco Romani has posted comments on this change. Change subject: vm: small cleanup of _completeIncomingMigration() ......................................................................
Patch Set 1: (1 comment) I like this direction but we need to clarify a bit the code here. https://gerrit.ovirt.org/#/c/47086/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2752: fromSnapshot = self.conf.pop('restoreFromSnapshot', False) Line 2753: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf, Line 2754: {'FROM_SNAPSHOT': fromSnapshot}) Line 2755: elif 'migrationDest' in self.conf: Line 2756: if not self._checkMigrationCompletedDuringRecovery(): let's find a better (= more expressive) name maybe _needToWaitForMigrationToComplete or _migrationStillNotComplete or something along these lines Line 2757: usedTimeout = self._waitForUnderlyingMigration() Line 2758: self._attachLibvirtDomainAfterMigration( Line 2759: self._incomingMigrationFinished.isSet(), usedTimeout) Line 2760: # else domain connection already established earlier -- To view, visit https://gerrit.ovirt.org/47086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1afb406e3e2ca7b37a621fc1bcc8bc1bf37031b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
