Francesco Romani has posted comments on this change. Change subject: vm: small cleanup of _completeIncomingMigration() ......................................................................
Patch Set 1: Code-Review-1 (2 comments) -1 for visibility https://gerrit.ovirt.org/#/c/47086/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-10-07 14:14:39 +0200 Line 4: Commit: Martin Betak <mbe...@redhat.com> Line 5: CommitDate: 2015-10-07 16:16:21 +0200 Line 6: Line 7: vm: small cleanup of _completeIncomingMigration() let's have a more descriptive subject line, something like migration: extract helper to check if migration completed or something like this. Line 8: Line 9: Extracted the check for recovery completion into separate method to simplify Line 10: consequent migration enhancements. Line 11: https://gerrit.ovirt.org/#/c/47086/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2776: self.log.info("End of migration") Line 2777: Line 2778: def _checkMigrationCompletedDuringRecovery(self): Line 2779: if not self.recovering: Line 2780: return False you can just extract this snippet into a function without changing the logic. Maybe a little bit clearer. Line 2781: Line 2782: try: Line 2783: if self._isDomainRunning(): Line 2784: self.log.info('migration completed while recovering!') -- To view, visit https://gerrit.ovirt.org/47086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1afb406e3e2ca7b37a621fc1bcc8bc1bf37031b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
