Dan Kenigsberg has posted comments on this change. Change subject: net: tests: additional tests for host QOS ......................................................................
Patch Set 12: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44699/12/tests/tcTests.py File tests/tcTests.py: Line 418: self.assertEqual(len(tc_filters.tagged_filters), 1) Line 419: self.assertEqual(tc_filters.tagged_filters[0]['u32']['flowid'], Line 420: ':%x' % vlan.tag) Line 421: Line 422: def test_multiple_vlans(self): I suppose you should mock your libvirtconnection 07:37:35 ERROR: test_multiple_vlans (tcTests.TestConfigureOutbound) 07:37:35 ---------------------------------------------------------------------- 07:37:35 Traceback (most recent call last): 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/tests/tcTests.py", line 427, in test_multiple_vlans 07:37:35 vlan_id=v.tag, nics=(self.device_name, )) 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/vdsm/network/api.py", line 127, in _objectivizeNetwork 07:37:35 _netinfo = netinfo.NetInfo() 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/lib/vdsm/netinfo.py", line 858, in __init__ 07:37:35 _netinfo = get() 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/lib/vdsm/netinfo.py", line 756, in get 07:37:35 libvirt_nets = networks() 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/lib/vdsm/netinfo.py", line 132, in networks 07:37:35 conn = libvirtconnection.get() 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/lib/vdsm/libvirtconnection.py", line 161, in get 07:37:35 password = ProtectedPassword(passwd.libvirt_password()) 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/lib/vdsm/utils.py", line 859, in __call__ 07:37:35 value = self.func(*args) 07:37:35 File "/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/lib/vdsm/tool/configurators/passwd.py", line 75, in libvirt_password 07:37:35 with open(LIBVIRT_PASSWORD_PATH) as passwd_file: 07:37:35 IOError: [Errno 2] No such file or directory: '/etc/pki/vdsm/keys/libvirt_password' Line 423: with vlan_device(self.device_name, tag=16) as vlan1: Line 424: with vlan_device(self.device_name, tag=17) as vlan2: Line 425: for v in (vlan1, vlan2): Line 426: net_ent = api._objectivizeNetwork( -- To view, visit https://gerrit.ovirt.org/44699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibad639a9ad04593cfd477f60a8272614f3446522 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
