Dan Kenigsberg has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 12: Code-Review-1 (2 comments) very partial review https://gerrit.ovirt.org/#/c/46448/12/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 117: Line 118: EXT_IFDOWN = '@IFDOWN_PATH@' Line 119: EXT_IFUP = '@IFUP_PATH@' Line 120: EXT_IONICE = '@IONICE_PATH@' Line 121: EXT_IPERF3 = '@IPERF3_PATH@' constants.py is a junkyard. I don't see any chance of iperf being used outside the test. Please use CommandPath to resolve the path during runtime. Line 122: EXT_ISCSIADM = '@ISCSIADM_PATH@' Line 123: EXT_TC = '@TC_PATH@' Line 124: Line 125: EXT_KILL = '@KILL_PATH@' https://gerrit.ovirt.org/#/c/46448/12/tests/nettestlib.py File tests/nettestlib.py: Line 277: self._threads = threads Line 278: self._raw_output = None Line 279: Line 280: def start(self): Line 281: cmd = [EXT_IPERF3, '--client', self._server_ip, please use IPERF_BINARY.cmd. Line 282: '--version4', # only IPv4 Line 283: '--time', str(self._test_time), '--parallel', Line 284: str(self._threads), '--bind', self._bind_to, Line 285: '--zerocopy', # use less cpu -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
