Dan Kenigsberg has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 18: (3 comments) https://gerrit.ovirt.org/#/c/46448/18/tests/nettestlib.py File tests/nettestlib.py: Line 23: import json Line 24: import os Line 25: import platform Line 26: import signal Line 27: import struct "time" should be imported here (part of stdlib) Line 28: from contextlib import contextmanager Line 29: from multiprocessing import Process Line 30: Line 31: from nose.plugins.skip import SkipTest Line 289: sleep(3) apologize for this Line 370: return f(*a, **kw) Line 371: return wrapper Line 372: Line 373: Line 374: def check_iperf(): should be private. might be simpler with if not os.access(_IPERF3_BINARY.cmd, X_OK): raise SkipTest() Line 375: try: Line 376: execCmd([_IPERF3_BINARY.cmd, "--version"]) Line 377: except OSError as e: Line 378: if e.errno == errno.ENOENT: -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
