Yeela Kaplan has posted comments on this change. Change subject: log: failure in logging ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/47522/3/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 140: def log_info(self, message, type='info'): Line 141: level = getattr(logging, type.upper(), None) Line 142: if not isinstance(level, int): Line 143: raise ValueError('Invalid log level: %s' % type) Line 144: self._log.log(level, message) > self._log is a class attribute - accessing class attribute is the same, jus I mean that _log is 'static' so why access it as 'self._log'. Also log_info was a member of cls which is 'static', and not of 'self' which is the object instantiated from the class - 'non static'. Line 145: Line 146: Line 147: class AsyncoreEvent(asyncore.file_dispatcher): Line 148: def __init__(self, map=None): -- To view, visit https://gerrit.ovirt.org/47522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2396d1ec98987064134af334ff0a2a4dab78d836 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
