Piotr Kliczewski has posted comments on this change. Change subject: log: failure in logging ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/47522/3/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 134 Line 135 Line 136 Line 137 Line 138 > Current python code does not use it, any future version may use it. If we o Looking at asyncore.dispatcher I can see that signature of both debug and log methods are compatible. Log method is more restrictive but we won't see any issues with this assignment. -- To view, visit https://gerrit.ovirt.org/47522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2396d1ec98987064134af334ff0a2a4dab78d836 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
