Martin Polednik has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place ......................................................................
Patch Set 1: Code-Review+1 (2 comments) A little concern regarding importing Error directly to module's namespaces - I'd rather see 'utils' namespace used. Opinionated, therefore not -1 worthy. On the other hand, big thanks for taking the initiative - this is very needed effort. https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/taskset.py File lib/vdsm/taskset.py: Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: Line 23: from .utils import Error Not really needed due to utils imported later - I'd say raise utils.Error rather then directly importing it. Minor. Line 24: from . import constants Line 25: from . import utils Line 26: Line 27: https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/udevadm.py File lib/vdsm/udevadm.py: Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: import logging Line 23: from .utils import Error Same as taskset. Line 24: from . import utils Line 25: Line 26: _UDEVADM = utils.CommandPath("udevadm", "/sbin/udevadm", "/usr/sbin/udevadm") Line 27: -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
