Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/taskset.py File lib/vdsm/taskset.py: Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: Line 23: from .utils import Error > Not really needed due to utils imported later - I'd say raise utils.Error r Yes, here I cut one corner. We have one problem in client code: - now existing code is catching taskset.Error (or udevadm.Error, or whatever), which is nice and expressive - after this change, we either add bogus import (ugly and repetitive) or we catch utils.Error, which is a little ugly and reads worse. Line 24: from . import constants Line 25: from . import utils Line 26: Line 27: -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches