Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/47964/4//COMMIT_MSG Commit Message: Line 10: they raise when one command run through utils.execCmd fails. Line 11: Line 12: Since this Error is closely related to utils.execCmd, we Line 13: remove the duplicate definition of Error and we move it Line 14: in one place, alongside execCmd itself. You did not move execCmd in this patch (and lets keep it simple and not move it now), so better remove that part of the sentence. Line 15: Line 16: Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
