Nir Soffer has posted comments on this change.

Change subject: lib: utils: consolidate Error class in one place
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:

Line 27: 
Line 28: SUDO_NON_INTERACTIVE_FLAG = "-n"
Line 29: 
Line 30: 
Line 31: class Error(Exception):
> As in the commit message this Error is closely related to utils.execCmd so 
The name is meaningful - cmdutils.Error

You are supposed to do:

    import cmdutils

    try:
        ...
    except cmdutils.Error:
        ...

Just like socket.error, thread.error.
Line 32: 
Line 33:     def __init__(self, rc, out, err):
Line 34:         self.rc = rc
Line 35:         self.out = out


-- 
To view, visit https://gerrit.ovirt.org/47964
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to