Nir Soffer has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48217/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 888: return Line 889: Line 890: # When attaching hosted engine storage domain, sanlock is already Line 891: # maintaning a lockspace on this domain, and releasing the host id Line 892: # would cause sanlock to kill the hosted engine vm. > Arguably this is true whenever attaching a domain with running VMs on it (e No, vms are not using sanlock yet. Line 893: # See https://bugzilla.redhat.com/1269768 Line 894: shouldAcquireHostId = not dom.hasHostId(self.id) Line 895: Line 896: if shouldAcquireHostId: -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
