Martin Sivák has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48217/1//COMMIT_MSG Commit Message: Line 8: Line 9: When attaching hosted engine storage domain, sanlock is already Line 10: maintaining a lockspace on the domain, and releasing the host id would Line 11: cause sanlock to kill the hosted engine vm. Line 12: > According to Roy, sanlock is killing the qemu process running the hosted en Not exacly. Hosted engine has its own lockspace for keeping track of hosted engine IDs. Those IDs have nothing to do with VDSM. VDSM probably has its own lockspace too (for SPM?). The last locked piece is the hosted engine VM's hard disk. I am not sure which lockspace is used there, but the lock is asked for by QEMU while starting the VM (using arguments provided by vdsm via libvirt). Hosted engine (agent) does not have any lock with regards to the VM. Line 13: Now we acquire and release the host id during attach only if needed, Line 14: keeping hosted engine vm alive. Line 15: Line 16: Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
