Zhou Zheng Sheng has posted comments on this change. Change subject: [WIP] Add text-based console support ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm/consoleServer.py Line 26: import select Line 27: import os Line 28: import threading Line 29: import errno Line 30: I guess He Jie is following PEP8 http://www.python.org/dev/peps/pep-0008/#imports Imports should be grouped in the following order: standard library imports related third party imports local application/library specific imports You should put a blank line between each group of imports. Since paramiko is third party lib we add blank lines around this group. Line 31: import paramiko Line 32: Line 33: from vdsm import constants Line 34: from vdsm.betterPopen import BetterPopen Line 76: sock.close() Line 77: continue Line 78: return p, sock Line 79: Line 80: raise Exception("can not allocated any port on %s", self._addr) Agree Line 81: Line 82: def setTicket(self, passwd, timeout, connAct): Line 83: try: Line 84: return self._crabRPCProxy.callCrabRPCFunction(10, "setTicket", -- To view, visit http://gerrit.ovirt.org/7165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69904bf7aafd4f764a256d4075c9bf71d988e7c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
