Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Add text-based console support
......................................................................
Patch Set 2: (2 inline comments)
(just a glimpse)
....................................................
File vdsm/supervdsmServer.py
Line 278: def removeFs(self, path):
Line 279: return mkimage.removeFs(path)
Line 280:
Line 281: @logDecorator
Line 282: def changePtyOwner(self, ptyNum):
can we somehow limit this to ptys connected to qemu processes?
Line 283: if type(ptyNum) != int:
Line 284: raise TypeError("ptyNum must be integer")
Line 285:
Line 286: cmd = [EXT_CHOWN, "vdsm:kvm", "/dev/pts/" + str(ptyNum)]
Line 282: def changePtyOwner(self, ptyNum):
Line 283: if type(ptyNum) != int:
Line 284: raise TypeError("ptyNum must be integer")
Line 285:
Line 286: cmd = [EXT_CHOWN, "vdsm:kvm", "/dev/pts/" + str(ptyNum)]
os.chown() would be more concise.
Line 287: rc, out, err = storage.misc.execCmd(cmd, sudo=False)
Line 288: if rc:
Line 289: raise OSError(errno.EINVAL, "can not change own of
/dev/pts/%d, " \
Line 290: "out: %s\nerr: %s" %
--
To view, visit http://gerrit.ovirt.org/7165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69904bf7aafd4f764a256d4075c9bf71d988e7c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
