Francesco Romani has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats ......................................................................
Patch Set 3: Code-Review+2 (1 comment) please plan some tests for this patch. It is fine if you add them in a future patch, but let's improve the test coverage of v2v.py. https://gerrit.ovirt.org/#/c/48129/3/vdsm/v2v.py File vdsm/v2v.py: Line 737: Line 738: def _read_ovf_from_ova(ova_path): Line 739: ''' Line 740: virt-v2v support ova in tar, zip formats as well as Line 741: extracted directory I don't like - the use of ''' instead of """ - the extra indent inside the docstring but this is VERY minor - please update only if you have to resubmit for more important reasons. Line 742: ''' Line 743: if os.path.isdir(ova_path): Line 744: return _read_ovf_from_ova_dir(ova_path) Line 745: elif zipfile.is_zipfile(ova_path): -- To view, visit https://gerrit.ovirt.org/48129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I494b88709c4c23fd39690b589eff1134e74f81ba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
