Francesco Romani has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats ......................................................................
Patch Set 4: Code-Review-1 (1 comment) one question inside, -1 for visibility. https://gerrit.ovirt.org/#/c/48129/4/vdsm/v2v.py File vdsm/v2v.py: Line 769: def _read_ovf_from_zip_ova(ova_path): Line 770: with open(ova_path, 'rb') as fh: Line 771: zf = zipfile.ZipFile(fh) Line 772: name = _find_ovf(zf.namelist()) Line 773: if name is not None and '.ovf' == os.path.splitext(name)[1].lower(): ok, but the right side of the 'and' looks redundant: don't we do this very check in _find_ovf? Line 774: return zf.read(name) Line 775: raise ClientError('OVA does not contains file with .ovf suffix') Line 776: Line 777: -- To view, visit https://gerrit.ovirt.org/48129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I494b88709c4c23fd39690b589eff1134e74f81ba Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
