Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1590: 
Line 1591:     def _buildDomainXML(self):
Line 1592:         for consoleDev in self._devices[hwclass.CONSOLE]:
Line 1593:             if consoleDev.isSerial:
Line 1594:                 break
> nice refactoring, but not needed for this patch.
please discard this comment.
Line 1595:         else:
Line 1596:             consoleDev = None
Line 1597:         self.conf['_serialConsoleAvailable'] = consoleDev is not None
Line 1598: 


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to