Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py File tests/vmTests.py: Line 1: # Line 2: # Copyright IBM Corp. 2012 Line 3: # Copyright 2013-2015 Red Hat, Inc. > there is not such habit. A separate copyright-bump patch will probably a be Done Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 6: # it under the terms of the GNU General Public License as published by Line 7: # the Free Software Foundation; either version 2 of the License, or Line 1418: 'specParams': {'consoleType': console_type}}, Line 1419: with fake.VM(devices=devices, create_device_objects=True) as v: Line 1420: dom_xml = v._buildDomainXML() Line 1421: self.assertEqual('<bios useserial="yes"/>' in dom_xml, Line 1422: use_serial) > Could'nt that be solved by some monkeypatching? I don't get how monkeypatching could help here. Basically, we need to check that _buildDomainXML correctly identifies presence of a serial console, passes correct argument to appendOs and appendOs produces correct output. Line 1423: Line 1424: Line 1425: def _load_xml(name): Line 1426: test_path = os.path.realpath(__file__) https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1: # Line 2: # Copyright 2008-2015 Red Hat, Inc. > correct, but unneeded here Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/48404/1/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 1: # Line 2: # Copyright 2008-2015 Red Hat, Inc. > correct, but unneeded for this patch. Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/48404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
