Dan Kenigsberg has posted comments on this change. Change subject: Update MTU when removing one of networks with custom MTU from NIC/bond ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1050: configWriter._updateConfigValue(cf, 'BRIDGE', '', True) Line 1051: Line 1052: # Now we can restart changed interface Line 1053: ifdown(iface) Line 1054: ifup(iface) it's a bit complex - are you sure you are not ifup'ing a device that is going to be removed few lines below? it can be a huge waste of time. Line 1055: Line 1056: # The (relatively) new setupNetwork verb allows to remove a network Line 1057: # defined on top of an bonding device without break the bond itself. Line 1058: if implicitBonding: -- To view, visit http://gerrit.ovirt.org/7749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b91127c170b94871b1ae717f3d51f5fa86c7ac3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
