Antoni Segura Puimedon has posted comments on this change. Change subject: Update MTU when removing one of networks with custom MTU from NIC/bond ......................................................................
Patch Set 2: (1 inline comment) I'm not sure that the name changing is important, but in general I like the patch for the mere fact that it increases readability. I don't see how it changes the MTU updating though. .................................................... File vdsm/configNetwork.py Line 1035: configWriter.removeBridge(network) Line 1036: Line 1037: iface = bonding if bonding else nics[0] Line 1038: if vlan: Line 1039: configWriter.removeVlan(vlan, iface) This three lines above look clearer now. I like it. Line 1040: else: Line 1041: cf = configWriter.NET_CONF_PREF + iface Line 1042: if not bridged: Line 1043: # When removing bridgeless non-VLANed network -- To view, visit http://gerrit.ovirt.org/7749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b91127c170b94871b1ae717f3d51f5fa86c7ac3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
