Sahina Bose has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48308/2/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 337: raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount) Line 338: Line 339: def _get_backup_servers_option(self): Line 340: servers = [brick.split(":")[0] for brick in self.volinfo['bricks']] Line 341: self._volfileserver = servers.pop(0) > There is a major issue with this change. Yes, it will work as long as server IP/FQDN configured in bricks is reachable by hypervisor host mounting it. Line 342: if not servers: Line 343: return "" Line 344: Line 345: return "backup-volfile-servers=" + ":".join(servers) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches