Sahina Bose has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 347: Line 348: if not servers: Line 349: return "" Line 350: Line 351: return "backup-volfile-servers=" + ":".join(servers) > Ala, would add a patch of top of this one, removing duplicates? Yes, there could be any number of backup-volfile-servers - and each will be tried in turn. The volfile-servers provided is for the gluster client to fetch the volfile from and is only used at the time of mounting volume. Once the volfile is retrieved from any of these servers, gluster client knows of all the servers in the cluster and will intelligently connect to them. To answer the second question - no, failure to connect to any of the servers while mounting volume does not result in bricks being marked down. Brick process is monitored separately by the glusterd services running on the servers. Line 352: Line 353: def _get_gluster_volinfo(self): Line 354: volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname, Line 355: self._volfileserver) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches