Francesco Romani has posted comments on this change. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade ......................................................................
Patch Set 1: Code-Review-1 (2 comments) please check inline comment. I guess we can't really do much better to fix this issue, so let's bite the bullet. https://gerrit.ovirt.org/#/c/48621/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1814: # So, to get proper device objects during VM recovery flow Line 1815: # we must to have updated conf before VM run Line 1816: self.saveState() Line 1817: else: Line 1818: self._fixLegacyGraphicsConf() ok for rename (strict process mandates to do it in a separate patch, but I don't mind), but please keep the comment here. If you want to move it, make it a docstring. But this has to be done in a separate patch. Line 1819: Line 1820: self._devices = self.devMapFromDevSpecMap(dev_spec_map) Line 1821: Line 1822: # We should set this event as a last part of drives initialization Line 4975: self.conf['devices'].extend(self.getConfGraphics()) Line 4976: Line 4977: # We need to clean out unknown devices that are created for Line 4978: # RNG devices by VDSM 3.5 and are left in the configuration Line 4979: # after upgrade to 3.6. same: either move it in the call site or make it a docstring. Line 4980: def _fixLegacyRngConf(self): Line 4981: with self._confLock: Line 4982: self._devices[hwclass.RNG] = [dev for dev in self._devices[hwclass.RNG] Line 4983: if 'source' in dev.specParams] -- To view, visit https://gerrit.ovirt.org/48621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2580dcb335970a4bb5c4c87fe6ea9fcd8e494df5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
