Dan Kenigsberg has posted comments on this change.

Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48621/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1741:             raise 
MissingLibvirtDomainError(vmexitreason.LIBVIRT_START_FAILED)
Line 1742: 
Line 1743:         self._updateDomainDescriptor()
Line 1744: 
Line 1745:         # We need to clean out unknown devices that are created for
please use the

  REQUIRED_FOR migrate from vdsm-XXX

so it's easier to find and remove.
Line 1746:         # RNG devices by VDSM 3.5 and are left in the configuration
Line 1747:         # after upgrade to 3.6.
Line 1748:         self._fixLegacyRngConf()
Line 1749: 


-- 
To view, visit https://gerrit.ovirt.org/48621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2580dcb335970a4bb5c4c87fe6ea9fcd8e494df5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to