Dan Kenigsberg has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................
Patch Set 13: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/iscsi.py
Line 354: processes = []
Line 355: minTimeout = config.getint('irs', 'scsi_rescan_minimal_timeout')
Line 356: maxTimeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357: for hba in glob.glob(SCAN_PATTERN):
Line 358: cmd = ['echo', '- - -', '|', '/bin/dd of=' + hba]
Yeela, would you please elaborate how you have verified this patch? To me it
seems that the process you create is echoing the string
"- - - | /bin/dd of=hba"
to standard output, and immediately exits.
On a side note, we have constants.EXT_DD.
Line 359: processes.append((hba, misc.execCmd(cmd, sudo=False,
sync=False)))
Line 360: if (minTimeout > maxTimeout or minTimeout < 0):
Line 361: minTimeout = 2
Line 362: maxTimeout = 30
Line 357: for hba in glob.glob(SCAN_PATTERN):
Line 358: cmd = ['echo', '- - -', '|', '/bin/dd of=' + hba]
Line 359: processes.append((hba, misc.execCmd(cmd, sudo=False,
sync=False)))
Line 360: if (minTimeout > maxTimeout or minTimeout < 0):
Line 361: minTimeout = 2
I'd appreciate a commit message explanation on why minTimeout is useful. (I
really do not understand. Replacing two sleeps of 1 second with one sleep of 2
seconds does not seem very important to me)
Line 362: maxTimeout = 30
Line 363: log.warning("One of the following configuration arguments has
an ",
Line 364: "illegal value: scsi_rescan_minimal_timeout or ",
Line 365: "scsi_rescan_maximal_timeout. Set to %s and %s
seconds ",
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
