Dan Kenigsberg has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File vdsm/storage/iscsi.py
Line 356: maxTimeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357: for hba in glob.glob(SCAN_PATTERN):
Line 358: cmd = [constants.EXT_DD, 'of=' + hba]
Line 359: p = misc.execCmd(cmd, sudo=False, sync=False)
Line 360: p.stdin.write("- - -")
that's saner than adding tipple-dash.txt file. but why not use the
recently-fixed "data" argument to execCmd?
Line 361: p.stdin.flush()
Line 362: p.stdin.close()
Line 363: processes.append((hba, p))
Line 364: if (minTimeout > maxTimeout or minTimeout < 0):
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
