Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: perform reboot asynchronously ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) (I'm not the python purist you make of me!) .................................................... File vdsm_reg/deployUtil.py.in Line 181: try: Line 182: pid = os.fork() Line 183: if pid == 0: Line 184: try: Line 185: os.setsid() It seems that you are re-implementing parts of vdsm_reg/createDaemon.py. Would it be sufficient to do createDaemon.createDaemon() time.sleep(10) _logExec(reboot) Line 186: for fd in range(0, maxfd): Line 187: try: Line 188: os.close(fd) Line 189: except OSError: # ERROR, fd wasn't open to begin with (ignored) Line 196: if os.fork() != 0: Line 197: os._exit(0) Line 198: Line 199: time.sleep(10) Line 200: os.execl(EX_REBOOT, EX_REBOOT) do you intentionally call reboot, with the argument "/sbin/reboot"? Line 201: finally: Line 202: os._exit(1) Line 203: Line 204: pid, status = os.waitpid(pid, 0) -- To view, visit http://gerrit.ovirt.org/7783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0abb02ae4d5033a8b9f2d468da86fcdc53e2e1c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
