Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: perform reboot asynchronously
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 163: Escape '&', '<', '>', and '\n' in a given string.
Line 164: """
Line 165: return saxutils.escape(message, XML_QUOTES)
Line 166:
Line 167: def simpleDaemon(main, arg):
it would be even cooler to have
def simpleDaemon(main, args=(), kwargs={}):
here....
Line 168: # Default maximum for the number of available file descriptors.
Line 169: MAXFD = 1024
Line 170:
Line 171: import resource # Resource usage information.
Line 189:
Line 190: if os.fork() != 0:
Line 191: os._exit(0)
Line 192:
Line 193: main(arg)
...and call
main(*args, **kwargs)
here. this would allow most-generic function calls.
Line 194: finally:
Line 195: os._exit(1)
Line 196:
Line 197: pid, status = os.waitpid(pid, 0)
--
To view, visit http://gerrit.ovirt.org/7783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0abb02ae4d5033a8b9f2d468da86fcdc53e2e1c2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
