Fabian Deutsch has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir ......................................................................
Patch Set 2: (1 comment) Right, I'm also fine with that. Let me push aa patch with a more generic function which illustrates how config file reading should be improved. https://gerrit.ovirt.org/#/c/48317/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 455: config = ConfigParser.ConfigParser() Line 456: set_defaults(config) Line 457: Line 458: # Read from teh config file first Line 459: vdsmconf [os.path.join('@CONFDIR@', 'vdsm.conf')] > s/teh/the Doh - Yes, I'll fix it. Line 460: config.read([os.path.join('@CONFDIR@', 'vdsm.conf')]) Line 461: Line 462: # Also read files in the drop-in dir Line 463: vdsmconfd = vdsmconf + '.d') -- To view, visit https://gerrit.ovirt.org/48317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
