Fabian Deutsch has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48317/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 454: Line 455: config = configparser.ConfigParser() Line 456: set_defaults(config) Line 457: Line 458: def read_configs(pkgname, paths=["/usr/lib/", "/run/", "/etc/"]): This is how (roughly) config file reading should work for all our components, it would very much help to separate defaults/vendor presets from user changes, and it can improve the Node experience. Line 459: """This function is reading config files in a specific scheme Line 460: Line 461: The function reads - for one component - config files from several Line 462: locations and in addition it is also reading configuration snippets -- To view, visit https://gerrit.ovirt.org/48317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
