Francesco Romani has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole ......................................................................
Patch Set 5: Code-Review+1 (1 comment) minor comment inside https://gerrit.ovirt.org/#/c/48404/5/tests/vmTests.py File tests/vmTests.py: Line 292: @permutations([['serial', True], ['virtio', False]]) Line 293: def testSerialBios(self, console_type, use_serial): Line 294: devices = {'device': 'console', 'type': 'console', Line 295: 'specParams': {'consoleType': console_type}}, Line 296: with fake.VM(devices=devices, create_device_objects=True) as v: minor: we usually avoid so short names. "fakevm" or "testvm" could be a better choice here. Line 297: dom_xml = v._buildDomainXML() Line 298: tree = etree.fromstring(dom_xml) Line 299: element = tree.find(".//bios[@useserial='yes']") Line 300: self.assertEqual(element is not None, use_serial) -- To view, visit https://gerrit.ovirt.org/48404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
