Martin Betak has posted comments on this change. Change subject: virt: introduce "Async" helper ......................................................................
Patch Set 2: I'm going to have to agree with Milan. We need to ask ourselves, what we are getting in exchange for all this complexity. If it is really just to put the acquire and release a little bit closer together, I would say we are making a bad trade-off, both in readability (understandability) and future maintanability of the code. -- To view, visit https://gerrit.ovirt.org/49114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd277197c7c3819008ae71a8cf2c0679b901397e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches