Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper ......................................................................
Patch Set 2: Martin, I think we can go with Async if we can simplify it. E.g. how about something like the following in do(): self._started = threading.Event() ... start the thread .. self._started.wait() # for set() in _set_started We could eliminate some Async attributes + maybe error(). My primary concern is what error() is actually for. -- To view, visit https://gerrit.ovirt.org/49114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd277197c7c3819008ae71a8cf2c0679b901397e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
