Adam Litke has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/41998/17/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 202: """ Line 203: # Just call the SD Manifest method getVSize() - apparently it does what Line 204: # we need. We consider incurred overhead of producing the object Line 205: # to be a small price for code de-duplication. Line 206: manifest = blockSD.BlockStorageDomainManifest(self.sdUUID) > This bypass the sd cache, which is nice, since I like to get rid of it. But Sure. I will pull in a new patch and we can use the sdCache as follows: manifest = sdCache.produce(self.sdUUID).get_manifest() Line 207: return int(manifest.getVSize(self.imgUUID, self.volUUID) / bs) Line 208: Line 209: getVolumeTrueSize = getVolumeSize Line 210: -- To view, visit https://gerrit.ovirt.org/41998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
