Freddy Rolland has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize
......................................................................


Patch Set 22: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41998/22/vdsm/storage/fileVolume.py
File vdsm/storage/fileVolume.py:

Line 594:     def getVolumeSize(self, bs=BLOCK_SIZE):
        :         """
        :         Return the volume size in blocks
        :         """
        :         volPath = self.getVolumePath()
        :         return int(int(self.oop.os.stat(volPath).st_size) / bs)
        : 
        :     def getVolumeTrueSize(self, bs=BLOCK_SIZE):
        :         """
        :         Return the size of the storage allocated for this volume
        :         on underlying storage
        :         """
        :         volPath = self.getVolumePath()
        :         return int(int(self.oop.os.stat(volPath).st_blocks) * 
BLOCK_SIZE / bs)
These need to be deleted


-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to