Dan Kenigsberg has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File vdsm/dsaversion.py.in: Line 34: version_info = { Line 35: 'version_name': version_name, Line 36: 'software_version': software_version, Line 37: 'software_revision': software_revision, Line 38: 'supportedENGINEs': ['3.4', '3.5', '3.6', '4.0'], that fine... Line 39: 'clusterLevels': ['3.4', '3.5', '3.6', '4.0'], Line 40: } Line 41: Line 42: if platform.machine() == 'ppc64le': Line 39: '4.0' but we do not support 4.0 clusterLevel yet... We have not even defined what this clusterLevel is. -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
