Piotr Kliczewski has posted comments on this change. Change subject: code coverage: change approach how to enable it ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 406: Line 407: ('coverage_enable', 'false', Line 408: 'Enable code coverage (requires python-coverage package). ' Line 409: 'false by default. Use environment file /etc/sysconfig/vdsm to ' Line 410: 'set COVERAGE_PROCESS_START and COVERAGE_FILE variables.'), > And of course, vdsm-coverage will require python-coverage, so you don't hav I agree with Nir. It would be great if I could see how well my code is covered by tests and improve it in my dev env. Line 411: Line 412: ]), Line 413: Line 414: # Section: [gluster] -- To view, visit https://gerrit.ovirt.org/49168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Balogh <pbal...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Balogh <pbal...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
