Petr Balogh has posted comments on this change. Change subject: code coverage: change approach how to enable it ......................................................................
Patch Set 2: I tested it on my engine(10.34.63.122) and host(10.34.63.123). There are standard passwords (if you don't know them ping me on IRC and I'll send it to you) applied patch to this two files on host: /usr/share/vdsm/vdsm and /usr/lib/python2.7/site-packages/vdsm/config.py . Than I added /etc/sysconfig/vdsm which contains: COVERAGE_PROCESS_START=/etc/vdsm/coveragerc.conf COVERAGE_FILE=/var/log/vdsm/coverage_data and /etc/vdsm/coveragerc.conf which contains: http://pastebin.test.redhat.com/331121 I've put devel section and coverage_enable = true to config Than I've put host to maintenance, stopped vdsm on host, start vdsm.. activated host in engine.. And again maintenance, stop vdsm . And after stop vdsm you can see /var/log/coverage_data file . And you can see report with command: coverage report --rcfile=/etc/vdsm/coveragerc.conf . Also tried remove coverage_enable from config and it doesn't start coverage.. So would you like from me to create another patch which will create vdsm-coverage. So it's about add things to vdsm.spec.in file isn't it? Or put it together with this patch? Thanks -- To view, visit https://gerrit.ovirt.org/49168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Balogh <pbal...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Balogh <pbal...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches