Dan Kenigsberg has posted comments on this change. Change subject: report idle time for multiple vcpus ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 163: netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name) Line 164: return netSamples Line 165: Line 166: def _getCpuStats(self, stats): Line 167: nbVirtCPU = self._vm._dom._dom.info()[3] nb? I think libvirt docs use "nr". http://libvirt.org/html/libvirt-libvirt.html#virDomainInfo Line 168: stats['cpuSys'] = 0.0 Line 169: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats() Line 170: Line 171: try: Line 173: except (TypeError, ZeroDivisionError): Line 174: self._log.debug("CPU stats not available") Line 175: stats['cpuUser'] = 0.0 Line 176: Line 177: stats['cpuIdle'] = max(0.0, (100.0 * nbVirtCPU) - stats['cpuUser']) I have a vague memory that Engine and its reports would be very sad about this change. Please get their acks. Line 178: Line 179: def _getNetworkStats(self, stats): Line 180: stats['network'] = {} Line 181: sInfo, eInfo, sampleInterval = self.sampleNet.getStats() -- To view, visit http://gerrit.ovirt.org/7892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
