Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 173: except (TypeError, ZeroDivisionError):
Line 174: self._log.debug("CPU stats not available")
Line 175: stats['cpuUser'] = 0.0
Line 176:
Line 177: stats['cpuIdle'] = max(0.0, (100.0 * nbVirtCPU) -
stats['cpuUser'])
Good point, I will ask the guys on the engine-devel list. I took a short look
into the engine code but it seems it is not really used. It is kept in the DB
after polling the VDSM, but not actually used for anything.
Line 178:
Line 179: def _getNetworkStats(self, stats):
Line 180: stats['network'] = {}
Line 181: sInfo, eInfo, sampleInterval = self.sampleNet.getStats()
--
To view, visit http://gerrit.ovirt.org/7892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
