Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
......................................................................
Patch Set 7: (1 inline comment)
In general it looks good... a minor comment.
....................................................
File vdsm/storage/volume.py
Line 823: Derived classes can use this if they want to represent the
Line 824: volume to the VM in a different way than the standard 'path'
way.
Line 825: """
Line 826: # By default, send path
Line 827: return {'volType': 'path', 'path': self.getVolumePath()}
Please find a suitable name/place for enumerating those macros eg:
class VolumeInfo(object):
TYPE_PATH = "path"
...
So that then you can use:
return {'volType': VolumeInfo.TYPE_PATH, 'path': self.getVolumePath()}
etc...
Line 828:
Line 829: def getMetaParam(self, key):
Line 830: """
Line 831: Get a value of a specific key
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
