Nir Soffer has posted comments on this change. Change subject: sp: Allow attaching of monitored domain ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48217/2/vdsm/storage/monitor.py File vdsm/storage/monitor.py: Line 101: if monitor is not None: Line 102: self.log.debug("Monitor for %s is running", sdUUID) Line 103: if poolDomain: Line 104: self.log.info("Attaching monitor for %s to the pool", sdUUID) Line 105: monitor.poolDomain = True > I would add a comment here that from now on external monitoring is joint in Improved in next version. Line 106: return Line 107: Line 108: self.log.info("Start monitoring %s", sdUUID) Line 109: monitor = MonitorThread(weakref.proxy(self), sdUUID, hostId, -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
