Liron Aravot has posted comments on this change. Change subject: sp: Allow attaching of monitored domain ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/48217/4/vdsm/storage/monitor.py File vdsm/storage/monitor.py: Line 100: Line 101: # TODO: Replace with explicit attach. Line 102: if monitor is not None: Line 103: if not poolDomain: Line 104: # Expected when hosted engnine agent is restarting. /s/engnine/engine I'd remove the hosted engine comment, the monitor shouldn't refer on comments to his callers (and theoretically, the engine may call this to monitor a non pool domain which isn't related to the hosted engine). Line 105: self.log.debug("Monitor for %s is already running", sdUUID) Line 106: return Line 107: Line 108: if monitor.poolDomain: -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
