Ondřej Svoboda has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring ......................................................................
Patch Set 8: Code-Review+1 Nice reimplementation. One question though: Ido will be moving more networking code to lib/vdsm soon. Are you planning to reuse some facilities (such as the constant '# Generated by VDSM version' in ifcfg.ConfigWriter or hopefully some functions) from the library then? netinto.NET_CONF_DIR could be used right away instead of NETWORK_SCRIPTS but I don't mind if this happens later and it is a "constant" constant anyway. -- To view, visit https://gerrit.ovirt.org/46148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches