Ido Barkan has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/46148/9/init/wait_for_ipv4s File init/wait_for_ipv4s: Line 39: devs consider renaming this parameter and its usage to ifcfgs or devs_ifcfgs (or a better name) as those are file names. Line 47: label isn't this the name of the device? if so, why not name it as such? -- To view, visit https://gerrit.ovirt.org/46148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
