Francesco Romani has posted comments on this change. Change subject: vm: always return bond mode in Host.getCapabilities ......................................................................
Patch Set 1: Code-Review-1 (2 comments) a question inside https://gerrit.ovirt.org/#/c/49550/1//COMMIT_MSG Commit Message: Line 6: Line 7: vm: always return bond mode in Host.getCapabilities Line 8: Line 9: The 'mode' attribute in bonding options should always be returned in Line 10: Host.getCapabilities. please add a bit more context explaining how removing 'mode' by defaults helps here. Line 11: Line 12: Change-Id: I697af1c895db5ece99b3f940242b77f623caa8b9 Line 13: Bug-Url: https://bugzilla.redhat.com/1276445 https://gerrit.ovirt.org/#/c/49550/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 445: """ Line 446: opts = bondOpts(bond) Line 447: mode = opts['mode'][-1] if 'mode' in opts else None Line 448: defaults = getDefaultBondingOptions(mode) Line 449: defaults.pop('mode', None) > optionaly: I like 'pop' more. :) Line 450: Line 451: return dict(((opt, val[-1]) for (opt, val) in opts.iteritems() Line 452: if val and val != defaults.get(opt))) Line 453: -- To view, visit https://gerrit.ovirt.org/49550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I697af1c895db5ece99b3f940242b77f623caa8b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
