Zhou Zheng Sheng has posted comments on this change.
Change subject: Make netinfo.py PEP8 clean
......................................................................
Patch Set 4: Verified; Looks good to me, but someone else must approve
Looks OK.
pydiff says,
pydiff netinfo*.py
2 difference(s)
first file: netinfoo.py
second file: netinfo.py
((170, "Name('ValueError')"),
(191,
"CallFunc(Name('ValueError'), [Mod((Const('unknown bridge %s'),
Name('bridge')))], None, None)"))
((170, Mod((Const('unknown bridge %s'), Tuple([Name('bridge')])))),
(191, None))
This is actually changing the way of raising exception. It's acceptable.
--
To view, visit http://gerrit.ovirt.org/7922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3ee6348a0a9eb4366b1571ab5883deba9b40d0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
