Daniel Erez has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 530: return meta Line 531: Line 532: @classmethod Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type, voltype, Line 534: disktype, desc="", legality=ILLEGAL_VOL): readability - consider moving 'voltype' to the prefix of this line... Line 535: return { Line 536: FORMAT: str(format), Line 537: TYPE: str(type), Line 538: VOLTYPE: str(voltype), -- To view, visit https://gerrit.ovirt.org/44045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches