Daniel Erez has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 521: def createMetadata(cls, metaId, meta): Line 522: cls._putMetadata(metaId, meta) Line 523: Line 524: @classmethod Line 525: def newMetadata(cls, metaId, sdUUID, imgUUID, puuid, size, format, type, It might be confusing to understand the difference between newMetadata and makeMetadata methods.. Can you please add some documentation the clarify and explain when one should use which? Line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL): Line 527: meta = cls.makeMetadata(sdUUID, imgUUID, puuid, size, format, type, Line 528: voltype, disktype, desc, legality) Line 529: cls.createMetadata(metaId, meta) -- To view, visit https://gerrit.ovirt.org/44045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
